Forms: Remove MailPoet integration feature flag

[edanzer]

Fixes FORMS-263

Proposed changes:

This removes the feature flag for MailPoet integration. We do not expose this on simple, but it will be fully released to Atomic when deployed there, and will go out with next Jetpack release in early September.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

P2: peKye1-1I2-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

SIMPLE TEST INSTRUCTIONS: Just confirm MailPoet section appears without feature flag, and play with MailPoet settings to confirm they appear.

DETAILED TEST INSTRUCTIONS (if you want them):

• Prep: If you've tested this before, be sure to remove the MailPoet feature flag. You no longer need to add a MailPoet key to start adding contacts to your lists.
• Test forms integration dashboard:
  • Go to Jetpack > Forms > Integrations and confirm the MailPoet section appears.
  • Try installing / activating the plugin here and confirm state updates as expected.
  • If prompted, complete MailPoet setup.
  • If active and set up is complete, confirm you see the link to the MailPoet dashboard, and it works.
• Test form block in editor:
  • Add a form to a page or post. Your form must have an email field with label of "Emai" or id of "email". If you include a name field with 'First Name' label or 'firstname' id, that will be added to your lists. If you include a name field with 'Last Name' label or 'lastname' id, that will be added to your lists.
  • Open the integration modal and confirm the MailPoet section appears.
  • Enable MailPoet using the toggle on the top.
  • Select a desired MailPoet list where you want to add contacts (skip consent for now)
• Test frontend submission: Go to frontend, submit, and confirm subscriber was added to MailPoet list.
• Test consent: In the block editor, you can the toggle to add the consent field. Test frontend form submission with different consent stats.
  • No consent field: contact will be added to MailPoet
  • Consent field with no checkbox: contact will be added to MailPoet
  • Consent field with 'checked' checkbox: contact will be added to MailPoet
  • Consent field with 'unchecked' checkbox: contact will not be added to MailPoet

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/forms-mailpoet-remove-feature-flag branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/forms-mailpoet-remove-feature-flag

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly:
  • Scheduled release: September 2, 2025
  • Code freeze: September 1, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form-plugin.php	404/1197 (33.75%)	0.50%	-6 💚

Full summary · PHP report · JS report

[CGastrell]

• Test forms integration dashboard
• Go to Jetpack > Forms > Integrations and confirm the MailPoet section appears.
• Try installing / activating the plugin here and confirm state updates as expected.
• If prompted, complete MailPoet setup.

Didn't get prompted.

• If active and set up is complete, confirm you see the link to the MailPoet dashboard, and it works.
• Test form block in editor:
• Add a form to a page or post. Your form must have an email field with label of "Emai" or id of "email". If you include a name field with 'First Name' label or 'firstname' id, that will be added to your lists. If you include a name field with 'Last Name' label or 'lastname' id, that will be added to your lists.
• Open the integration modal and confirm the MailPoet section appears.
• Enable MailPoet using the toggle on the top.
• Select a desired MailPoet list where you want to add contacts (skip consent for now)
• Test frontend submission:
• Go to frontend, submit, and confirm subscriber was added to MailPoet list.
• Test consent: In the block editor, you can the toggle to add the consent field. Test frontend form submission with different consent stats.
• No consent field: contact will be added to MailPoet
• Consent field with no checkbox: contact will be added to MailPoet
• Consent field with 'checked' checkbox: contact will be added to MailPoet

** THIS DIDN'T WORK **: adding consent field and checking made the subscriber to NOT reach the list. I did get the response on Jetpack > Forms dashboard though.

• Consent field with 'unchecked' checkbox: contact will not be added to MailPoet

** THIS DIDN'T WORK **: same as above, it made no difference checking/unchecking the consent, the subscriber didn't make it to the list but I got the response on Jetpack > Forms.

Non blocking, but I saw this error when I uncollapsed the MailPoet card on integrations modal on the editor (happens only once, reload to see it again), couldn't confirm it also happens on integrations tab:

Also non blocking, one of those warnings about deprecated props on gutenberg:

[simison]

Also non blocking, one of those warnings about deprecated props on Gutenberg:

Fix:

• Forms: integrations - opt-in toggle controls into 'next no margin' #44817

[edanzer]

Since this PR was originally prepared:

• I merged a fix for the dom nesting console error @CGastrell found above (PR)
• I merged a fix for the toggle styles console error @CGastrell found above and @simison fixed above (PR)
• I refactored the MailPoet integration class to fully use the new Feedback class (PR)
  • The MailPoet refactor included a fix for @CGastrell's issue with consent checkboxes above, which was related to translations and not checking the value of 'consent' properly. Fix is here.
  • The MailPoet refactor also depended on two other PRs to Add html ids to Feedback class and save forms using new data format from @enejb

So all known issues are fixed now and the MailPoet_Integration class is fully working based on the new Feedback class and logic.

[CGastrell]

Works nicely!