Skip to content

Charts: Re-allow typechecking of tests and stories #45082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2025
Merged

Charts: Re-allow typechecking of tests and stories #45082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e795dfb
Remove 'exclude' field from tsconfig to allow typechecking of tests a…
adamwoodnz Sep 5, 2025
040f9f3
Add changelog
adamwoodnz Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/js-packages/charts/changelog/charts-113-remove-tsconfig-exclude-field
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Charts: Allow typechecking of tests and stories
4 changes: 3 additions & 1 deletion projects/js-packages/charts/src/components/line-chart/stories/tooltip.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import { RenderTooltipParams } from '@visx/xychart/lib/components/Tooltip';
import { ChartStoryArgs } from '../../../stories';
import { DataPointDate } from '../../../types';
import LineChart from '../line-chart';
import { lineChartMetaArgs, lineChartStoryArgs } from './config';
import type { Meta, StoryFn, StoryObj } from '@storybook/react';
Expand Down Expand Up @@ -57,7 +59,7 @@ CrosshairHorizontal.args = {
export const Custom: StoryObj< typeof LineChart > = Template.bind( {} );
Custom.args = {
...tooltipStoryArgs,
renderTooltip: ( { tooltipData } ) => {
renderTooltip: ( { tooltipData }: RenderTooltipParams< DataPointDate > ) => {
const nearestDatum = tooltipData?.nearestDatum?.datum;
if ( ! nearestDatum ) return null;

Expand Down
3 changes: 1 addition & 2 deletions projects/js-packages/charts/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@
"outDir": "dist",
"rootDir": "src"
},
"include": [ "src" ],
"exclude": [ "tests", "**/*.test.*", "stories", "**/*.stories.*" ]
"include": [ "src" ]
}
Loading