Skip to content

Conversation

dilirity
Copy link
Member

@dilirity dilirity commented Sep 5, 2025

Fixes HOG-325, related to #45008

Proposed changes:

  • Add missing includes in pre-wordpress part of Boost.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

HOG-325

Does this pull request change what data or activity we track or use?

no

Testing instructions:

Pre-requisites

  • You'll need to test this on a multisite with 2 sites. I'll call these site A, and B. I used Local to setup one (Jurassic Ninja might work as well, but I didn't use it);
  • Install Jetpack Beta as a network plugin so you can easily switch the Boost version;

Test that it breaks

  • From Jetpack Beta, make sure you're on the trunk or the production version of Boost;
  • On site A, activate Jetpack Boost and Page Cache. Make sure page cache works as expected;
  • On site B, make sure Jetpack Boost is disabled. Try editing a page and you should see an error.

Test that it breaks

  • Keep the same setup as above, but switch to (fix/boost/page-cache/multisite-update-page-fatal-hog-325) from Jetpack Beta;
  • On site B, try editing a page and it should work without a problem.

@dilirity dilirity self-assigned this Sep 5, 2025
@dilirity dilirity added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Plugin] Boost A feature to speed up the site and improve performance. [Boost Feature] Page Cache I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. labels Sep 5, 2025
Copy link
Contributor

github-actions bot commented Sep 5, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/boost/app/modules/optimizations/page-cache/pre-wordpress/class-boost-cache.php 29/293 (9.90%) 1.25% 0 💚

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

Copy link
Contributor

@LiamSarsfield LiamSarsfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can confirm this works as expected.

@dilirity dilirity merged commit eda78d8 into trunk Sep 11, 2025
81 of 82 checks passed
@dilirity dilirity deleted the fix/boost/page-cache/multisite-update-page-fatal-hog-325 branch September 11, 2025 07:13
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Boost Feature] Page Cache I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Plugin] Boost A feature to speed up the site and improve performance. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants