Skip to content

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Oct 2, 2025

Part of DOTCOM-14866

Proposed changes:

Removes the Calypsoify package since it was only used to enable the fullscreen mode on the block editor, but turns out that's the default mode nowadays.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Apply these changes to your WP.com site
  • Click on "New > Post" in the admin bar
  • Make sure the calypsoify param is not in the URL
  • Make sure the fullscreen mode is enabled by default

@mmtr mmtr requested a review from a team October 2, 2025 14:40
@mmtr mmtr self-assigned this Oct 2, 2025
@mmtr mmtr requested a review from jeherve as a code owner October 2, 2025 14:40
@mmtr mmtr added [Status] Needs Review This PR is ready for review. [Type] Task labels Oct 2, 2025
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the dotcom-14866-remove-calypsoify branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack dotcom-14866-remove-calypsoify
bin/jetpack-downloader test jetpack-mu-wpcom-plugin dotcom-14866-remove-calypsoify

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Oct 2, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Mu Wpcom plugin:

  • Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

jp-launch-control bot commented Oct 2, 2025

Code Coverage Summary

Coverage changed in 3 files.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php 0/323 (0.00%) 0.00% -1 💚
projects/packages/jetpack-mu-wpcom/src/features/wpcom-block-editor/class-jetpack-wpcom-block-editor.php 28/265 (10.57%) 0.04% -1 💚
projects/packages/jetpack-mu-wpcom/src/features/wpcom-wpadmin-page-view/wpcom-wpadmin-page-view.php 14/53 (26.42%) 1.42% -3 💚

Full summary · PHP report · JS report

jeherve added a commit that referenced this pull request Oct 3, 2025
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we remove the package entirely from the repo, what would you say for an additional PR that would just edit the package's composer.json and readme.md to mark it as deprecated, so the mirror repo gets updated one last time. Something like #45366.

@mmtr
Copy link
Member Author

mmtr commented Oct 6, 2025

what would you say for an additional PR that would just edit the package's composer.json and readme.md to mark it as deprecated, so the mirror repo gets updated one last time. Something like #45366.

Sounds good!

jeherve added a commit that referenced this pull request Oct 6, 2025
* Calypsoify: mark package as abandoned

See #45356

* Update lock files
jeherve
jeherve previously approved these changes Oct 6, 2025
@jeherve jeherve force-pushed the dotcom-14866-remove-calypsoify branch from 7e7bdf4 to 6827929 Compare October 6, 2025 09:09
@mmtr mmtr merged commit af0d2a5 into trunk Oct 6, 2025
139 of 144 checks passed
@mmtr mmtr deleted the dotcom-14866-remove-calypsoify branch October 6, 2025 10:02
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants