Skip to content

Conversation

lezama
Copy link
Contributor

@lezama lezama commented Oct 2, 2025

Proposed changes:

Optimizes the has_feedback() method in the Forms dashboard to improve performance on sites with large numbers.

Other information:

  • Have you written new tests for your changes, if applicable? N/A - optimization only
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Performance optimization discussed internally.

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Prerequisites:

  • Site with Jetpack Forms active
  • Ideally, a site with many feedback entries (spam, responses, etc.) for meaningful testing

Steps:

  1. Go to Jetpack → Forms in the admin dashboard
  2. Open browser DevTools → Network tab
  3. Look for the /wp-json/wp/v2/feedback/config request
  4. Check the response time

Expected behavior:

  • Request should complete quickly (<50ms on most sites)
  • Dashboard should load faster
  • No functional changes to the UI or data returned

This is part of a larger effort: #45339

Copy link
Contributor

github-actions bot commented Oct 2, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-optimize-has-feedback-query branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-optimize-has-feedback-query

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Oct 2, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 2, 2025
Copy link

jp-launch-control bot commented Oct 2, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/dashboard/class-dashboard.php 23/83 (27.71%) 5.63% 0 💚

Full summary · PHP report · JS report

@enejb enejb force-pushed the update/forms-optimize-has-feedback-query branch from b4c95d9 to 8891313 Compare October 8, 2025 19:03
@enejb enejb requested a review from Copilot October 8, 2025 19:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the has_feedback() method in the Forms dashboard to improve performance by modifying the query to only fetch what's necessary to determine if feedback exists.

  • Limits query to fetch only 1 post instead of all feedback posts
  • Disables unnecessary caching and metadata loading
  • Changes return logic to use have_posts() instead of found_posts

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
projects/packages/forms/src/dashboard/class-dashboard.php Optimizes the feedback existence check query with performance parameters
projects/packages/forms/changelog/update-optimize-has-feedback-query Adds changelog entry documenting the performance optimization

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@@ -0,0 +1,4 @@
Significance: patch
Type: fixed
Copy link
Preview

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog type should be 'changed' rather than 'fixed' since this is a performance optimization, not a bug fix.

Suggested change
Type: fixed
Type: changed

Copilot uses AI. Check for mistakes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes things for sites with really large DBs.

@enejb enejb merged commit d5795ab into trunk Oct 8, 2025
67 checks passed
@enejb enejb deleted the update/forms-optimize-has-feedback-query branch October 8, 2025 19:34
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 8, 2025
@lezama
Copy link
Contributor Author

lezama commented Oct 8, 2025

This is part of a larger effort: #45339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants