-
Notifications
You must be signed in to change notification settings - Fork 835
Newsletter Settings: add clarify to clarify reply-to settings #45368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected for me!
Aside, my 2cents: it feels weird having this new descriptor conditionally in the headline above the settings. Being detached from the specific relevant setting, having a delay after clicking the setting, the message showing up appended to another line further above after the delay.... etc.... it feels easier to miss compared to just putting on the individual option's description directly.
And move the explanations below the radio / fields. This will bring this settings section more in line with its Calypso counterpart.
That's a good point. The Calypso settings actually look a bit better in that regard, if only because the explanations are displayed below the fields and because we have 2 separate sections. I think we could improve things a bit by making the settings here more like the Calypso ones. I just pushed a commit, ce8fafe, to give you an idea of what I think: Before ![]() After ![]() Let me know what you think. It doesn't address all your concerns, but I think it makes the extra appended message a bit more bearable. |
Fixes CML-934
Proposed changes:
When one enables the option for replies to be sent to the post author's email, this will only work if the post author has linked their account to their WordPress.com account.
We want to highlight that in the newsletter settings. We've discussed multiple options in CML-934, and ended up with this choice:
Since we only want to show that option on self-hosted sites, we won't be adding it to the Calypso UI here:
https://github.com/Automattic/wp-calypso/blob/a6947294442abc306659ccf8c4e2e35fd9460edd/client/my-sites/site-settings/settings-newsletter/ReplyToSetting.tsx#L53
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: