Skip to content

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Oct 3, 2025

Fixes CML-934

Proposed changes:

When one enables the option for replies to be sent to the post author's email, this will only work if the post author has linked their account to their WordPress.com account.

We want to highlight that in the newsletter settings. We've discussed multiple options in CML-934, and ended up with this choice:

image image

show the highlighted text when the “Replies will be sent to the post author’s email” option is selected AND the current site is self-hosted?

Since we only want to show that option on self-hosted sites, we won't be adding it to the Calypso UI here:
https://github.com/Automattic/wp-calypso/blob/a6947294442abc306659ccf8c4e2e35fd9460edd/client/my-sites/site-settings/settings-newsletter/ReplyToSetting.tsx#L53

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Go to Jetpack > Settings > Newsletter
  • Enable the feature
  • Scroll down to "Sender name and reply-to settings"
  • Pick "Replies will be sent to the post author's email"
  • See the text changing just above.

@jeherve jeherve self-assigned this Oct 3, 2025
@jeherve jeherve added [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. Enhancement [Status] Needs Review This PR is ready for review. [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Admin Page React-powered dashboard under the Jetpack menu labels Oct 3, 2025
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/newsletter-settings-clarify-reply-to branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/newsletter-settings-clarify-reply-to

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Oct 3, 2025
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: October 7, 2025
    • Code freeze: October 6, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jeherve jeherve requested a review from a team October 3, 2025 10:17
Copy link

jp-launch-control bot commented Oct 3, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Addison-Stavlo
Addison-Stavlo previously approved these changes Oct 3, 2025
Copy link
Contributor

@Addison-Stavlo Addison-Stavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected for me!

Aside, my 2cents: it feels weird having this new descriptor conditionally in the headline above the settings. Being detached from the specific relevant setting, having a delay after clicking the setting, the message showing up appended to another line further above after the delay.... etc.... it feels easier to miss compared to just putting on the individual option's description directly.

And move the explanations below the radio / fields.

This will bring this settings section more in line with its Calypso counterpart.
@jeherve
Copy link
Member Author

jeherve commented Oct 3, 2025

Aside, my 2cents: it feels weird having this new descriptor conditionally in the headline above the settings.

That's a good point. The Calypso settings actually look a bit better in that regard, if only because the explanations are displayed below the fields and because we have 2 separate sections. I think we could improve things a bit by making the settings here more like the Calypso ones.

I just pushed a commit, ce8fafe, to give you an idea of what I think:

Before

Screenshot 2025-10-03 at 19 00 42

After

image

Let me know what you think. It doesn't address all your concerns, but I think it makes the extra appended message a bit more bearable.

@jeherve jeherve requested a review from Addison-Stavlo October 3, 2025 17:04
@jeherve jeherve merged commit a6cf6bf into trunk Oct 8, 2025
67 checks passed
@jeherve jeherve deleted the fix/newsletter-settings-clarify-reply-to branch October 8, 2025 09:25
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu Enhancement [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants