Skip to content

Conversation

edanzer
Copy link
Contributor

@edanzer edanzer commented Oct 3, 2025

We must merge #45372 before this PR.

Proposed changes:

As of this PR, users can filter what integrations are enabled for Jetpack Forms.

In CIAB, we disable most. We found that when Google Drive is disabled, we still show the Google Drive export card in the forms dashboard, but the export button is a never ending spinner since have a separate check just for the button. This PR uses the new integrations store to check if Google is enabled, and if not, hide that card. It also updates the check on the Export button to use the same store-based check (we could skip this check since the whole card is now hidden).

Before
google-drive-not-hidden

After
google-drive-hidden

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  1. Test no regressions.
  • Go to Jetpack > Forms, click the Export button, and export your responses to Google. Everything should work as before.
  1. Test when Google is disabled.
  • Disable the Google Drive integrations by adding the snippet below.
  • Go to Jetpack > Forms. Click the Export button in the upper right. Confirm that the Google export card no longer shows in the modal.
add_filter( 'jetpack_forms_supported_integrations', function ( $integrations ) {
  unset( $integrations['google-drive'] ); // Hide Google Drive
  return $integrations;
} );

@edanzer edanzer requested a review from a team October 3, 2025 20:39
@edanzer edanzer self-assigned this Oct 3, 2025
@edanzer edanzer added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Pri] Normal [Package] Forms labels Oct 3, 2025
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-google-enabled-check branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-google-enabled-check

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Oct 3, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


🔴 Action required: Please add missing changelog entries for the following projects: projects/packages/forms

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Oct 3, 2025
@edanzer edanzer marked this pull request as draft October 3, 2025 20:41
Copy link

Code Coverage Summary

No summary data is available for parent commit c27a3d0, so cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, this should be updated once coverage for c27a3d0 is available.

Full summary · PHP report · JS report

@edanzer edanzer added the [Status] Needs Review This PR is ready for review. label Oct 3, 2025
@github-actions github-actions bot added [Status] In Progress and removed [Status] Needs Review This PR is ready for review. labels Oct 3, 2025
const list = store.getIntegrations() || [];
return { integration: list.find( ( i: Integration ) => i.id === 'google-drive' ) };
}, [] ) as { integration?: Integration };
const { refreshIntegrations } = useDispatch( INTEGRATIONS_STORE ) as IntegrationsDispatch;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file had an extra check for if Google was enabled using the useIntegrationStatus hook. Going forward, we'll want to use the new integrations store for single integrations checks like this too. The store allows for immediate checks without an extra endpoint call. You just check if a particular integration slug exists in the list of integrations. I've updated this file to do that. It also now uses the refreshIntegrations() method from the store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Contact Form [Package] Forms [Pri] Normal [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant