Skip to content

ci: Test against PHP 8.5 #45626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: trunk
Choose a base branch
from
Open

ci: Test against PHP 8.5 #45626

wants to merge 25 commits into from

Conversation

@tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Oct 24, 2025 •
edited
Loading

Closes MONOREP-166

Changes made in this PR:

  • Enabled PHP 8.5 + WP trunk. Once WP 6.9 is out we can switch to WP latest, but right now that just triggers tons of core deprecations.
  • Disabled CRM tests on PHP 8.5.
  • Added Test_Environment::maybe_set_reflectionproperty_or_reflectionmethod_as_accessible() as a helper function.
  • Replaced all ReflectionProperty::setAccessible() and ReflectionMethod::setAccessible() calls.

We can use these as a reference:

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@tbradsha tbradsha requested a review from a team October 24, 2025 19:13
@tbradsha tbradsha self-assigned this Oct 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add/ci-php-8.5 branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/ci-php-8.5

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/ci-php-8.5

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added Actions GitHub actions used to automate some of the work around releases and repository management Docs labels Oct 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: November 4, 2025
    • Code freeze: November 3, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Backup plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Search plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Social plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Starter Plugin plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Videopress plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Mu Wpcom plugin:

  • Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Inspect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Automattic For agencies client plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Classic Theme helper plugin plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Paypal Payment buttons plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

jp-launch-control bot commented Oct 24, 2025 •
edited
Loading

Code Coverage Summary

Coverage changed in 3 files.

File Coverage Δ% Δ Uncovered
projects/packages/test-environment/src/class-test-environment.php 18/27 (66.67%) -8.33% 3 ❤️‍🩹
projects/plugins/jetpack/sal/class.json-api-links.php 2/116 (1.72%) -0.01% 1 ❤️‍🩹
projects/plugins/wpcomsh/storage/storage.php 0/88 (0.00%) 0.00% 1 ❤️‍🩹

Full summary · PHP report · JS report

@tbradsha
Copy link
Contributor Author

Rebased after bumping Composer to 2.8.12: #45627

@github-actions github-actions bot added the [Plugin] CRM Issues about the Jetpack CRM plugin label Oct 24, 2025
@tbradsha
Copy link
Contributor Author

tbradsha commented Oct 24, 2025 •
edited
Loading

@mikestottuk CRM has dependencies not yet compatible with PHP 8.5, so I disabled testing for that version: aa940ec

   Problem 1
      - dompdf/dompdf is locked to version v2.0.8 and an update of this package was not requested.
      - dompdf/dompdf v2.0.8 requires phenx/php-svg-lib >=0.5.2 <1.0.0 -> satisfiable by phenx/php-svg-lib[0.5.4].
      - phenx/php-svg-lib 0.5.4 requires sabberworm/php-css-parser ^8.4 -> satisfiable by sabberworm/php-css-parser[v8.9.0].
      - sabberworm/php-css-parser v8.9.0 requires php ^5.6.20 || ^7.0.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0 -> your php version (8.5.0-dev) does not satisfy that requirement.

@github-actions github-actions bot added [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. labels Oct 27, 2025
@tbradsha tbradsha added the DO NOT MERGE don't merge it! label Oct 27, 2025
tbradsha added 22 commits October 27, 2025 20:02
@tbradsha
Add PHP 8.5 to CI testing
15436d3
@tbradsha
Address curl_close() deprecation in PHP 8.5
5968625 
* Remove comment in CRM
* Wrap call so it only runs on PHP <8.0
@tbradsha
Add changelog
c59ab2e
@tbradsha
CRM deps are not ready for PHP 8.5
f46c474
@tbradsha
Update composer.lock for CRM
88b6bb9
@tbradsha
Skip CRM + PHP 8.5 in a different way
db9f9a9
@tbradsha
Remove unneeded Phan comments
b07b3f9
@tbradsha
Add changelog
3d4ed72
@tbradsha
Remove noop calls to ReflectionProperty::setAccessible() and Reflecti…
11b2e1a 
…onMethod::setAccessible()
@tbradsha
Add changelogs
a14ae28
@tbradsha
Revert "Remove noop calls to ReflectionProperty::setAccessible() and …
829fb78 
…ReflectionMethod::setAccessible()"

This reverts commit 9d607c3.
@tbradsha
Test deprecation fix
20817d1
@tbradsha
Update changelogs
371d822
@tbradsha
Add changelog
75cb626
@tbradsha
Deprecation fix for connection
f80321c
@tbradsha
Test PHP 8.5 against WP trunk for now
05d3003
@tbradsha
And now the rest!
c04c13d
@tbradsha
Add automattic/jetpack-test-environment dev dep where needed
205542a
@tbradsha
More composer stuff
e96f1d0
@tbradsha
Add changelogs
d6100ea
@tbradsha
Fix null offset
5b97180
@tbradsha
Address final deprecation notices that are from core
90ce8ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tbradsha tbradsha

Labels

Actions GitHub actions used to automate some of the work around releases and repository management DO NOT MERGE don't merge it! Docs [Feature] Contact Form [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Feature] Publicize Now Jetpack Social, auto-sharing [Feature] WooCommerce Analytics [JS Package] Charts [JS Package] Publicize Components [mu wpcom Feature] Help Center [mu wpcom Feature] Wpcom Themes [Package] Account Protection [Package] Assets [Package] Connection [Package] Device Detection [Package] External Media [Package] Forms [Package] Image CDN [Package] Import [Package] Jetpack mu wpcom WordPress.com Features [Package] My Jetpack [Package] Patchwork Redefine Exit [Package] Publicize [Package] Search Contains core Search functionality for Jetpack and Search plugins [Package] Stats Admin [Package] Stats Data [Package] Subscribers Dashboard [Package] Sync [Package] Test Environment [Package] VideoPress [Package] WooCommerce Analytics Enhanced analytics for WooCommerce users [Plugin] Automattic For Agencies Client [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Classic Theme Helper Plugin [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Inspect [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Paypal Payment Buttons [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Plugin] Wpcomsh RNA [Status] In Progress [Tests] Includes Tests [Type] Janitorial

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tbradsha