Skip to content

Conversation

@edanzer
Copy link
Contributor

@edanzer edanzer commented Oct 28, 2025

Proposed changes:

We noticed that the forms plugin is making integrations-related API calls even if the integrations feature flag is set to off. This PR checks the feature flag before preloading or fetching the integrations endpoint.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Slack:

Does this pull request change what data or activity we track or use?

No:

Testing instructions:

First test for no regressions by making sure the integrations dashboard and modal loads like normal.

Then set turn off integrations with the filter below. Open your dev tools > network tab. Reload both the integrations dashboard and block editor and confirm no integration api calls.

@edanzer edanzer self-assigned this Oct 28, 2025
@edanzer edanzer added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Pri] Normal [Block] Contact Form Form block (also see Contact Form label) [Package] Forms labels Oct 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/forms-disable-integrations-api-call branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/forms-disable-integrations-api-call

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link

jp-launch-control bot commented Oct 28, 2025

Code Coverage Summary

Coverage changed in 4 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/dashboard/integrations/index.tsx 0/33 (0.00%) 0.00% 3 ❤️‍🩹
projects/packages/forms/src/blocks/contact-form/components/jetpack-integration-controls.js 0/16 (0.00%) 0.00% 2 ❤️‍🩹
projects/packages/forms/src/blocks/contact-form/shared/hooks/use-form-block-defaults.js 0/19 (0.00%) 0.00% 2 ❤️‍🩹
projects/packages/forms/src/dashboard/class-dashboard.php 23/98 (23.47%) -0.24% 1 ❤️‍🩹

Full summary · PHP report · JS report

@edanzer edanzer force-pushed the fix/forms-disable-integrations-api-call branch from 4b86578 to e2718b4 Compare October 29, 2025 20:46
@edanzer edanzer force-pushed the fix/forms-disable-integrations-api-call branch from 10dfaa4 to 47f5860 Compare October 30, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Package] Forms [Pri] Normal [Status] In Progress [Status] Needs Review This PR is ready for review. [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants