-
Notifications
You must be signed in to change notification settings - Fork 838
Forms: avoid api call if integrations are disabled #45668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 4 files.
|
4b86578 to
e2718b4
Compare
10dfaa4 to
47f5860
Compare
Proposed changes:
We noticed that the forms plugin is making integrations-related API calls even if the integrations feature flag is set to off. This PR checks the feature flag before preloading or fetching the integrations endpoint.
Other information:
Jetpack product discussion
Slack:
Does this pull request change what data or activity we track or use?
No:
Testing instructions:
First test for no regressions by making sure the integrations dashboard and modal loads like normal.
Then set turn off integrations with the filter below. Open your dev tools > network tab. Reload both the integrations dashboard and block editor and confirm no integration api calls.