Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: automatically disable guest authors #3345

Merged
merged 4 commits into from
Nov 5, 2024
Merged

feat: automatically disable guest authors #3345

merged 4 commits into from
Nov 5, 2024

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Aug 15, 2024 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

After the introduction of the Guest Contributor role, we now want to be more proactive and disable CAP's guest authors if the site is not using the feature yet.

CAP's Guest Authors feature will be disabled by default if there are no Guest Authors in the site. If you want to force enabling it, add the NEWSPACK_ENABLE_CAP_GUEST_AUTHORS constant to your wp-config.php file.

How to test the changes in this Pull Request:

  1. In a site that has some Guest Authors
  2. Enable this branch and confirm the feature is still enabled and working
  3. Check that the option was set: wp option get newspack_check_site_has_cap_guest_authors should return yes
  4. Delete all your guest authors (or start with a new site)
  5. Make sure to delete the option: wp option delete newspack_check_site_has_cap_guest_authors
  6. Load any page of the site again
  7. Confirm Guest Authors are disabled and you see our replacement page instead
  8. Confirm the option now has the value no
  9. Add define( 'NEWSPACK_ENABLE_CAP_GUEST_AUTHORS', true ); to wp-config
  10. Confirm CAP's Guest Authors are re-enabled

Testing CRON

  1. Repeat steps 1 to 4
  2. Run wp cron event run newspack_re_check_guest_authors
  3. Confirm Guest Authors are disabled and you see our replacement page instead
  4. Confirm the option now has the value no

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Aug 15, 2024
@leogermani leogermani self-assigned this Aug 15, 2024
@leogermani leogermani requested a review from a team as a code owner August 15, 2024 21:44
adekbadek
adekbadek approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described, but I wonder if the migration won't be too involving.

includes/plugins/co-authors-plus/class-guest-contributor-role.php Show resolved Hide resolved
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Aug 16, 2024
@leogermani leogermani added Work In Progress and removed [Status] Approved The pull request has been reviewed and is ready to merge labels Sep 20, 2024
@leogermani leogermani added [Status] Needs Review The issue or pull request needs to be reviewed and removed Work In Progress labels Oct 22, 2024
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Oct 24, 2024
@leogermani leogermani merged commit d0db6ba into trunk Nov 5, 2024
0 of 3 checks passed
@leogermani leogermani deleted the feat/automatically-disable-guest-authors branch November 5, 2024 12:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Hey @leogermani, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to it to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Nov 6, 2024
@semantic-release-bot
chore(release): 5.7.0-alpha.1 [skip ci]
3428f75 
# [5.7.0-alpha.1](v5.6.0...v5.7.0-alpha.1) (2024-11-06)

### Bug Fixes

* avoid duplicate info notices in email editors ([#3512](#3512)) ([d38fc1a](d38fc1a))
* **co-authors-plus:** CLI for migrating from CAP GA ([9a81584](9a81584))
* command to fix active subs w/ missing next_payment dates ([#3484](#3484)) ([2e05fd4](2e05fd4))
* php fatal and warning ([#3502](#3502)) ([e089172](e089172))
* **site-kit:** update logger cron to hourly interval ([#3485](#3485)) ([e3823e7](e3823e7))
* **webhooks:** deprecate global endpoint ([#3492](#3492)) ([63e8ab2](63e8ab2))
* **wp-6.7:** update radio control styles ([#3518](#3518)) ([831756e](831756e))

### Features

* add user name to woocommerce data events ([#3473](#3473)) ([5312d30](5312d30))
* automatically disable guest authors ([#3345](#3345)) ([d0db6ba](d0db6ba))
* **connections:** jetpack sso ([#3486](#3486)) ([123408e](123408e))
* display list remote name on newsletter wizard ([#3478](#3478)) ([cd0b859](cd0b859))
* **site-kit:** add logging when site kit disconnects ([#3472](#3472)) ([62bf98c](62bf98c))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.7.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 11, 2024
@semantic-release-bot
chore(release): 5.7.0 [skip ci]
b9fe1b9 
# [5.7.0](v5.6.1...v5.7.0) (2024-11-11)

### Bug Fixes

* avoid duplicate info notices in email editors ([#3512](#3512)) ([d38fc1a](d38fc1a))
* **co-authors-plus:** CLI for migrating from CAP GA ([9a81584](9a81584))
* command to fix active subs w/ missing next_payment dates ([#3484](#3484)) ([2e05fd4](2e05fd4))
* php fatal and warning ([#3502](#3502)) ([e089172](e089172))
* **site-kit:** update logger cron to hourly interval ([#3485](#3485)) ([e3823e7](e3823e7))
* **webhooks:** deprecate global endpoint ([#3492](#3492)) ([63e8ab2](63e8ab2))
* **wp-6.7:** update radio control styles ([#3518](#3518)) ([831756e](831756e))

### Features

* add user name to woocommerce data events ([#3473](#3473)) ([5312d30](5312d30))
* automatically disable guest authors ([#3345](#3345)) ([d0db6ba](d0db6ba))
* **connections:** jetpack sso ([#3486](#3486)) ([123408e](123408e))
* display list remote name on newsletter wizard ([#3478](#3478)) ([cd0b859](cd0b859))
* **site-kit:** add logging when site kit disconnects ([#3472](#3472)) ([62bf98c](62bf98c))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees

@leogermani leogermani

Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leogermani @matticbot @adekbadek