Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reader-registration-block): fix styles of newsletter lists #3523

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented Nov 5, 2024

All Submissions:

Changes proposed in this Pull Request:

Fixes a styling issue.

How to test the changes in this Pull Request:

  1. On trunk, ensure you have about five lists configured in the Enagement -> Newsletters settings, add descriptions to each to inflate the character count
  2. Add a Reader Registration block somewhere, enable "Enable newsletter subscription" in the "Newsletter Subscription" sidebar panel, toggle all available lists, publish
  3. Visit the front-end, observe the lists are cut off in the UI, not allowing to scroll up fully
  4. Switch to this branch, observe issue is gone

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 5, 2024
@adekbadek adekbadek requested a review from a team as a code owner November 5, 2024 12:51
Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not confirm the issue on my local (I had way more than 5 lists).. but after this things still look good

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 8, 2024
@adekbadek adekbadek merged commit 1e1d7a4 into trunk Nov 11, 2024
9 checks passed
@adekbadek adekbadek deleted the fix/registration-lists-css branch November 11, 2024 10:01
Copy link

Hey @, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to it to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-changelog [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants