Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pwa): enable SW file caching #3526

Merged
merged 1 commit into from
Nov 8, 2024
Merged

feat(pwa): enable SW file caching #3526

merged 1 commit into from
Nov 8, 2024

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented Nov 6, 2024

All Submissions:

Changes proposed in this Pull Request:

Replaces the Cache-Control header used for PWA'a service worker file, so that it can be cached.

Also moves the PWA plugin integration file to a more applicable place.

How to test the changes in this Pull Request:

  1. On trunk
  2. $ curl -I <site-url>/wp.serviceworker, observe the cache-control: no-cache header
  3. Switch to this branch, repeat, observe the Cache-Control: max-age=86400, must-revalidate header sent

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 6, 2024
@adekbadek adekbadek requested a review from a team as a code owner November 6, 2024 07:59
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 7, 2024
@adekbadek adekbadek merged commit 82af7d4 into trunk Nov 8, 2024
8 checks passed
@adekbadek adekbadek deleted the fix/pwa-sw-caching branch November 8, 2024 08:44
Copy link

github-actions bot commented Nov 8, 2024

Hey @, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to it to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants