fix(ia): core update nag margins

[miguelpeixe]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

1205919985867982-as-1208354721118905/f

Fixes the core update nag margins when navigating Newspack wizards for both full wizard pages and header-only:

	Before	After
Header-only
Wizard page

How to test the changes in this Pull Request:

1. Checkout this branch, navigate to the wizard pages and admin-header-only pages
2. Confirm the margins are correct, as in the images above

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[ronchambers]

Sorry @miguelpeixe - I accidentally merged this directly into epic/ia from my local. I meant to push up a recommendation for the CSS, but I ended up merging this PR along with merging my recommendation too! Sorry. Anyway, I hope you like what I have to say below because it's already all merged 😉 If you don't like the following then I can roll the code back.

In my review (and merge) I was able to get the CSS down to just one block. Please see:

55ee135

This one block of CSS works for both full-page react and admin-only too. Additionally I updated it to work not just on "update-nag" but for all notices. I adjusted the margin down to 20px instead of 25px to cut down on some of the whitespace when multiple notices are present. And finally the CSS is only applied to "above header" notices, not in "wrap" (content) notices. It's been thoroughly tested.

I'll attach some screenshots below.

[ronchambers]

Full React Page:

Admin Header Page:

[ronchambers]

I'm adding a "mental note" here because there are some wizard pages that don't show any admin notices at all. It took me a while to figure out why that was while I was doing testing.

Some examples are:

• /wp-admin/admin.php?page=newspack-settings#/
• /wp-admin/admin.php?page=advertising-display-ads#/

These pages don't show any admin notices due to lines:

newspack-plugin/includes/class-newspack.php

Lines 48 to 50 in 55ee135

	add_action( 'admin_notices', [ $this, 'remove_notifications' ], -9999 );
	add_action( 'network_admin_notices', [ $this, 'remove_notifications' ], -9999 );
	add_action( 'all_admin_notices', [ $this, 'remove_notifications' ], -9999 );

And function:

newspack-plugin/includes/class-newspack.php

Line 276 in 55ee135

public function remove_notifications() {

Just an FYI on why there are no notices on those pages.