Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ia): remove wp_enqueue_style for newsletter.css #3532

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

jaredrethman
Copy link
Collaborator

newsletter css is housed in commons

All Submissions:

Changes proposed in this Pull Request:

Removes enqueuing of newsletter css, the css can be found in commons bundle.

Screenshot 2024-11-07 at 10 30 40

How to test the changes in this Pull Request:

  1. Checkout this branch i.e. git checkout origin/fix/ia-newsletters-css
  2. Navigate to /wp-admin/edit.php?post_type=newspack_nl_cpt&page=newspack-newsletters#/
  3. Confirm network/console error is gone

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

newsletter css is housed in commons
@jaredrethman jaredrethman changed the title fix: remove wp_enqueue_style fix(ia): remove wp_enqueue_style for newsletter.css Nov 7, 2024
@jaredrethman jaredrethman marked this pull request as ready for review November 7, 2024 16:34
@jaredrethman jaredrethman requested a review from a team as a code owner November 7, 2024 16:34
@jaredrethman jaredrethman added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 7, 2024
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 7, 2024
@jaredrethman jaredrethman merged commit 76bbc77 into epic/ia Nov 7, 2024
9 checks passed
@jaredrethman jaredrethman deleted the fix/ia-newsletters-css branch November 7, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants