Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update plugin description #1182

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix: update plugin description #1182

merged 1 commit into from
Aug 14, 2023

Conversation

gamebits
Copy link
Contributor

@gamebits gamebits commented Aug 11, 2023

All Submissions:

Changes proposed in this Pull Request:

With AMP having been deprecated from the Newspack platform in H1 2023, it's no longer relevant to describe this plugin as "AMP-compatible overlay and inline Campaigns." This PR updates the "Description" and "Author URI" fields in the plugin header.

How to test the changes in this Pull Request:

No code has changed; no testing is needed.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

With AMP having been deprecated from the Newspack platform in H1 2023, it's no longer relevant to describe this plugin as "AMP-compatible overlay and inline Campaigns."
Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thanks for that

@dkoo dkoo merged commit 1fde2d5 into master Aug 14, 2023
1 check passed
@dkoo dkoo deleted the fix/plugin-description branch August 14, 2023 23:41
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.23.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

gamebits added a commit to Automattic/newspack-plugin that referenced this pull request Jan 25, 2024
Brings the plugin description in alignment with Automattic/newspack-popups#1182.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants