Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store prompt activation date #1340

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Aug 28, 2024

For future analytics purposes

All Submissions:

Changes proposed in this Pull Request:

Stores the activation date of the prompts so we can later use for analytics purposes

How to test the changes in this Pull Request:

  1. create or activate an inactive prompt
  2. Check that the activation_date metadata was created with the current date
  3. Deactivate the prompt
  4. Confirm the dectivation_date metadata was created with the current date
  5. Activate it again
  6. Confirm the activation date was updated

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

For future analytics purposes
@leogermani leogermani self-assigned this Aug 28, 2024
@leogermani leogermani requested a review from a team as a code owner August 28, 2024 21:30
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as described with a non-blocking question. How do you envision using this data?

includes/class-newspack-popups.php Show resolved Hide resolved
@leogermani
Copy link
Contributor Author

Working as described with a non-blocking question. How do you envision using this data?

It is (or was) part of the Product usage measurement project scope

@leogermani leogermani merged commit 2c11424 into trunk Sep 11, 2024
8 checks passed
@leogermani leogermani deleted the feat/store-prompt-activation-date branch September 11, 2024 16:31
matticbot pushed a commit that referenced this pull request Sep 20, 2024
# [3.1.0-alpha.1](v3.0.1...v3.1.0-alpha.1) (2024-09-20)

### Bug Fixes

* check for non-preview logged in user on account criteria ([#1347](#1347)) ([9f6f062](9f6f062))
* prioritize ras overlays for delayed prompts ([21c3091](21c3091))
* prioritize ras overlays for delayed prompts [#1341](#1341)  ([c0027d1](c0027d1))
* verify delayed prompt can still be displayed before showing ([#1344](#1344)) ([235f36b](235f36b))

### Features

* store prompt activation date ([#1340](#1340)) ([2c11424](2c11424))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Oct 8, 2024
# [3.1.0](v3.0.1...v3.1.0) (2024-10-08)

### Bug Fixes

* check for non-preview logged in user on account criteria ([#1347](#1347)) ([9f6f062](9f6f062))
* prioritize ras overlays for delayed prompts ([21c3091](21c3091))
* prioritize ras overlays for delayed prompts [#1341](#1341)  ([c0027d1](c0027d1))
* verify delayed prompt can still be displayed before showing ([#1344](#1344)) ([235f36b](235f36b))

### Features

* store prompt activation date ([#1340](#1340)) ([2c11424](2c11424))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants