fix: verify delayed prompt can still be displayed before showing #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is technically a fix for ras-acc, however this is still a general enhancement that applies outside of ras-acc, so targeting trunk for this. But let me know if you'd like me to open a new epic branch for this instead! |
laurelfulford
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Works as described! 🙌
I tested this against epic/ras-acc and it worked as described for both the registration prompt success message not showing, and a regular prompt showing after the RAS-ACC checkout was closed.
I also tested it against trunk, and the prompts kept working as expected (both for the registration, and a regular prompt).
chickenn00dle
deleted the
fix/prevent-registration-popups-when-logged-in
branch
matticbot
pushed a commit
that referenced
this pull request
Sep 20, 2024
# [3.1.0-alpha.1](v3.0.1...v3.1.0-alpha.1) (2024-09-20) ### Bug Fixes * check for non-preview logged in user on account criteria ([#1347](#1347)) ([9f6f062](9f6f062)) * prioritize ras overlays for delayed prompts ([21c3091](21c3091)) * prioritize ras overlays for delayed prompts [#1341](#1341) ([c0027d1](c0027d1)) * verify delayed prompt can still be displayed before showing ([#1344](#1344)) ([235f36b](235f36b)) ### Features * store prompt activation date ([#1340](#1340)) ([2c11424](2c11424))
|
🎉 This PR is included in version 3.1.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Oct 8, 2024
# [3.1.0](v3.0.1...v3.1.0) (2024-10-08) ### Bug Fixes * check for non-preview logged in user on account criteria ([#1347](#1347)) ([9f6f062](9f6f062)) * prioritize ras overlays for delayed prompts ([21c3091](21c3091)) * prioritize ras overlays for delayed prompts [#1341](#1341) ([c0027d1](c0027d1)) * verify delayed prompt can still be displayed before showing ([#1344](#1344)) ([235f36b](235f36b)) ### Features * store prompt activation date ([#1340](#1340)) ([2c11424](2c11424))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes https://app.asana.com/0/1207817176293825/1208253149260198/f
With ras-acc, it is now possible for segment conditions to change for the reader between when a delayed prompt is "queued" and when it is displayed. This PR adds a check for delayed prompts to ensure it should still be displayed before unhiding:
How to test the changes in this Pull Request:
To test, be sure to check out
epic/ras-accin blocks, theme, newsletters, and plugintrunkthe registration overlay will appear, but since you are signed in, you will see the success state of the registration block. On this branch, the overlay should no longer appear as the reader no longer matches the segment.Other information: