Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent extra scrollbar with certain settings #1354

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: prevent extra scrollbar with certain settings #1354

merged 1 commit into from
Oct 17, 2024

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

If you have a really specific set of settings, you can end up with two scrollbars on the campaign popups.

This came up in our RAS-ACC testing, but it affects trunk, too.

See: 1207817176293825-as-1208541857637839

How to test the changes in this Pull Request:

  1. On Mac, set scrollbars to always be visible under System Settings > Appearance.
  2. Set up a centred popup campaign, and give it a lot of content so it will scroll easily.
  3. Under the 'Styles' panel, set the modal to Hide Padding.
  4. Preview your prompt; if the modal doesn't fill the browser window, shrink the window until it's getting cut off at the bottom.
  5. Note you have two scrollbars: one for the popup content, and one for the popup's containing HTML element. It looks strange, and the outer scrolling isn't necessary since the inside also scrolls.

CleanShot 2024-10-17 at 10 28 46

  1. Apply the PR and run npm run build.
  2. Confirm that the double scrollbars go away, and you're left with just the one (necessary) one:

CleanShot 2024-10-17 at 10 26 33

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford requested a review from a team as a code owner October 17, 2024 17:29
chickenn00dle
chickenn00dle approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work @laurelfulford 🙌

@laurelfulford
Copy link
Contributor Author

Thanks @chickenn00dle!

@laurelfulford laurelfulford merged commit 5138051 into trunk Oct 17, 2024
9 checks passed
matticbot pushed a commit that referenced this pull request Nov 6, 2024
@semantic-release-bot
chore(release): 3.1.1-alpha.1 [skip ci]
5b1a0bb 
## [3.1.1-alpha.1](v3.1.0...v3.1.1-alpha.1) (2024-11-06)

### Bug Fixes

* prevent extra scrollbar ([#1354](#1354)) ([5138051](5138051))
* remove inline-block display type ([#1356](#1356)) ([d2b0f21](d2b0f21))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.1-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 11, 2024
@semantic-release-bot
chore(release): 3.1.1 [skip ci]
50c55c7 
## [3.1.1](v3.1.0...v3.1.1) (2024-11-11)

### Bug Fixes

* prevent extra scrollbar ([#1354](#1354)) ([5138051](5138051))
* remove inline-block display type ([#1356](#1356)) ([d2b0f21](d2b0f21))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chickenn00dle chickenn00dle chickenn00dle approved these changes

Assignees
No one assigned
Labels
ras-acc testing released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurelfulford @matticbot @chickenn00dle