Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid fatal on get_segments #1359

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Nov 5, 2024

All Submissions:

Changes proposed in this Pull Request:

Fixes an odd issue where this would break the sites in a combination of S3 Uploads and Newspack S3 Performance plugins...

See 1200550061930446-as-1203093685387025

How to test the changes in this Pull Request:

  1. Smoke test

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani self-assigned this Nov 5, 2024
@leogermani leogermani requested a review from a team as a code owner November 5, 2024 15:41
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird bug, but good to be defensive in this situation!

@leogermani leogermani merged commit 2fb88fb into trunk Nov 6, 2024
8 checks passed
@leogermani leogermani deleted the fix/avoid-fatal-on-segments branch November 6, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants