Skip to content

Conversation

@btsimonh
Copy link

@btsimonh btsimonh commented Nov 1, 2024

Thanks for contributing!

  • Have you updated CHANGELOG.md? - no it's not a version update

see

#2452

for details. we need the file in master else we won't see the action :(.

options:
- '["ubuntu-latest"]'
- '["windows-latest"]'
- '["macos-13"]'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- '["macos-13"]'
- '["macos-15-intel"]'

Replace GitHub Actions runner image macos-13 with macos-15-intel as recommended in:

The macOS 13 runner image will be retired by December 4th, 2025.

The currently available GitHub Actions macOS runners are:

macOS Version runner.arch
macos-13 X64
macos-14 ARM64
macos-15 ARM64
macos-15-intel X64
macos-26 ARM64
macos-latest ARM64

- '["20"]'
- '["21"]'
- '["22"]'
- '["18", "20", "22"]'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

23, 24, 25?

env:
CANVAS_VERSION_TO_BUILD: ${{ matrix.canvas_tag }}
steps:
- uses: actions/checkout@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: actions/checkout@v2
- uses: actions/checkout@v5

# branch's files
fetch-depth: 0

- uses: actions/setup-node@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: actions/setup-node@v1
- uses: actions/setup-node@v6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants