Stop Splitting Surrogates #882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test the changes on this Pull Request by downloading the APK here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Update the
simperiumdependency, which includes changes to stop the splitting of surrogate pairs that resulted in corrupted data in note content as described in Simperium/simperium-android#213.Test
🙂🙁in note.😱between🙂and🙁in note.🙂😱🙁in note.🙂😱🙁in note list.🙂😱🙁in note.Review
Only one developer is required to review these changes, but anyone can perform the review.
Release
These changes do not require release notes.