Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: use simplenote:user_id instead of wpcom:user_id for Tracks #3291

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

codebykat
Copy link
Member

@codebykat codebykat commented Feb 12, 2025

Fix

Will close #3290.

I'm not sure I fully understand this code, but it looks like we are at least attempting to use the WPCOM info if we have a cookie, but it is sending the email rather than the user ID (which we may not have access to).

I think (am concerned?) it might be falling back to anon in all cases where there is not a WPCOM login, rather than sending the Simplenote ID (email address).

Is it worth looking to see if we can instead submit these Tracks events using a different field, in the case where we have WPCOM login info? I'm not sure if we can use the email as a primary key for Tracks (not providing the ID field at all).

Test

Release

RELEASE-NOTES.md was updated with:

Updated the ID type used for analytics to avoid sending invalid WPCOM IDs

@codebykat codebykat self-assigned this Feb 12, 2025
@roundhill
Copy link
Contributor

I don't think we want to try and send wpcom info at all - makes no sense. This feels like we went about it all wrong originally - it should be sending up the Simplenote user's email if they are signed in, and not read any wpcom cookies or anything... weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracks event are using wrong user id type
2 participants