-
Notifications
You must be signed in to change notification settings - Fork 45
Move Sync connected sites to redux slice #1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Sync connected sites to redux slice #1680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed changes look great! I did not observe any regressions when testing connecting and reconnecting sites. 👍🏼
Considering the size of the PR it would be great if one more person could review it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me too, and I also didn't encounter any regressions when testing. The connected sites are persisted between app restarts and I can connect multiple sites just as on the trunk version. 👍
Connecting a new site:
CleanShot.2025-09-02.at.14.56.21.mp4
After restarting the app, connecting and removing an additional site:
CleanShot.2025-09-02.at.15.05.15.mp4
… console errors in the tests
Related issues
Proposed Changes
Testing Instructions
npm start
.Pre-merge Checklist