Skip to content

Conversation

nightnei
Copy link
Contributor

@nightnei nightnei commented Aug 18, 2025

Related issues

Proposed Changes

When user remopved all sites we render Select a site to view details what is not correct, since nothing to select. With this PR we are adjusting the empoty Studio page acording to the design RToz6tIuQ7nlZrikBte4GU-fi-9564_277581
But I slightly simplified it.

Testing Instructions

  1. Open Studio
  2. Remove all sites
  3. Assert taht you see the new copy
BEFORE AFTER
Screenshot 2025-08-18 at 19 02 02 Screenshot 2025-08-25 at 17 28 59

@nightnei nightnei self-assigned this Aug 18, 2025
@nightnei nightnei changed the title Adjust empty Studio page WIP (waiting answer from Marina) Adjust empty Studio page Aug 18, 2025
@nightnei nightnei changed the title WIP (waiting answer from Marina) Adjust empty Studio page Adjust empty Studio page Aug 25, 2025
@nightnei nightnei requested a review from a team August 25, 2025 15:20
Copy link
Contributor

@gcsecsey gcsecsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this @nightnei, this makes a nicer UX. Changes LGTM and it works well. :shipit:

Before After
Image Image

@nightnei nightnei force-pushed the update/adjustEmptyStudio branch from 245f2d7 to 25f7ed4 Compare August 25, 2025 16:21
@nightnei nightnei changed the title Adjust empty Studio page Create empty Studio page Aug 25, 2025
@nightnei nightnei changed the title Create empty Studio page Fix empty Studio state with a new page Aug 25, 2025
Copy link
Contributor

@gcsecsey gcsecsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the latest changes, the updated design looks good. 👍

Image

Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good and work as expected. 👌🏼 There's just one issue I noticed - that the Add site button is not visible. It only shows up on hover:

Screen.Capture.on.2025-08-26.at.10-29-39.mp4

@nightnei nightnei merged commit 7858b1e into trunk Aug 26, 2025
13 checks passed
@nightnei nightnei deleted the update/adjustEmptyStudio branch August 26, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants