Fix issue with class tracking not updating properly #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug where tracking methods were not executing properly due to incorrect visibility modifiers. The methods record_event and record_stats are registered as WordPress action hook callbacks but were marked as private, preventing WordPress from invoking them from outside the class context.
Key Changes:
- Changed
record_event()visibility fromprivatetopublicto allow WordPress action hooks to invoke it - Changed
record_stats()visibility fromprivatetopublicto allow WordPress action hooks to invoke it
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the visibility of the
record_eventandrecord_statsmethods to public to ensure proper tracking and functionality. This change addresses the issue of class tracking not updating as expected.