Limit term redirect to supported taxonomies #2734
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses unwanted 301 redirects caused by the ActivityPub router interfering with other plugins (like Polylang) that use the term_id query variable for different purposes. The fix adds a taxonomy check to ensure term redirects only occur for supported taxonomies (category and post_tag by default), with a filter to allow customization.
Key Changes:
- Added taxonomy validation before performing term redirects
- Introduced
activitypub_supported_taxonomiesfilter for extensibility - Prevents conflicts with other plugins using
term_idquery parameter
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
includes/class-router.php |
Added taxonomy check in template_redirect() method to limit redirects to supported taxonomies |
.github/changelog/fix-router-taxonomy-redirect |
Added changelog entry documenting the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
- Add tear_down() method for proper test cleanup - Save filter callbacks to variables for specific removal - Replace remove_all_filters() with targeted remove_filter() calls - Fix test_preview_template_filter to properly clean up its filter
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #2730
Fixes #2725
Proposed changes:
categoryandpost_tagby default)activitypub_supported_taxonomiesfilter to allow customizationterm_idfor different purposesOther information:
Testing instructions:
For #2730 (Polylang conflict):
/?s=testFor #2725 (Posts page redirect):
Changelog entry
Changelog Entry Details
Significance
Type
Message
Fixed unwanted 301 redirects on search and posts pages when using Polylang or similar plugins.