Add ReqwestRequestExecutor
behind reqwest-request-executor
Cargo feature
#613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
wp_api_integration_tests::AsyncWpNetworking
towp_api
crate by renaming it toreqwest_request_executor::ReqwestRequestExecutor
. It also removes theReqwestRequestExecutor::Default
implementation in favorReqwestRequestExecutor::new(danger_accept_invalid_certs: bool)
, since in production accepting invalid certificates is probably not the client would want. Note that, bothreqwest_request_executor
module and thereqwest
dependency are behindreqwest-request-executor
Cargo feature.ReqwestRequestExecutor
in its current state is probably not ready to be used in production. We have a couple unwraps we should remove and turn into appropriate errors. We are also lacking some of the extra error handling Swift client has. Having said that, I think it's best to make this move without any functional changes and open subsequent PRs for improvements. @jkmassel is already working on such improvements at the moment, so I don't want to create any conflicts with that.