Skip to content

Using nodegit-lfs in electron renderer #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Using nodegit-lfs in electron renderer #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1de0c0
Merge pull request #1 from Axosoft/master
TranceGeniK Mar 10, 2023
bdbce42
Use ipv4 localhost writing
TranceGeniK Mar 10, 2023
b1eac5a
Add environment variable to be able to use electron executable as nod…
TranceGeniK Mar 10, 2023
296b8d5
Use second result in the regex match to return the correct url
TranceGeniK Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/GitAskPass.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if (!request.property) {
const client = net.createConnection(
{
port: NODEGIT_LFS_ASKPASS_PORT,
host: 'localhost'
host: '127.0.0.1'
},
() => {
client.pipe(process.stdout);
Expand Down
2 changes: 1 addition & 1 deletion src/utils/authService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const ensureAuthServer = () => new Promise((resolve, reject) => {

tcpServer = net.createServer(socketListener);
tcpServer.on('error', reject);
tcpServer.listen({ port: 0, host: 'localhost' }, resolve);
tcpServer.listen({ port: 0, host: '127.0.0.1' }, resolve);
});

export const getAuthServerPort = () => (
Expand Down
3 changes: 2 additions & 1 deletion src/utils/spawnHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const parseUrlFromErrorMessage = (errorMessage) => {
let url = null;
const matches = regex.CREDENTIALS_NOT_FOUND.exec(errorMessage);
if (matches && matches.length > 1) {
([url] = matches);
([, url] = matches);
}
return url;
};
Expand Down Expand Up @@ -93,6 +93,7 @@ const spawn = async (command, stdin, opts = {}, credentialsCallback, repoPath =
opts,
{
env: {
ELECTRON_RUN_AS_NODE: 1,
GIT_TERMINAL_PROMPT: 0,
GIT_ASKPASS: getGitAskPassPath(),
NODEGIT_LFS_ASKPASS_STATE: credRequestId,
Expand Down