Base64 update#1
Closed
serprex wants to merge 8 commits intoAyush1325:base64-updatefrom
serprex:base64-update
Closed
Base64 update#1serprex wants to merge 8 commits intoAyush1325:base64-updatefrom serprex:base64-update
serprex wants to merge 8 commits intoAyush1325:base64-updatefrom
serprex:base64-update
Conversation
I found the docs a bit confusing/inconsistent here (https://docs.rs/headers/0.3.8/headers/struct.CacheControl.html#method.with_max_age) since Duration needn't be specified in seconds.
* Add cargo fmt --check to CI Grabbed the incantation from https://github.com/hyperium/hyper/blob/master/.github/workflows/CI.yml Was noticing that my editor was automatically doing this - and figured it's good form to use an autoformatter with default settings. * Add components: rustfmt
RFC8246 adds this https://www.rfc-editor.org/rfc/rfc8246. Reasonable documentation here https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control
Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
Owner
|
@serprex I think you already did the merge fix: hyperium@287bd81 |
Author
|
That commit was made by seanmonstar. No need for this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes merge conflict in hyperium#127
merge conflicts has to do with git getting confused in Cargo.toml with bitflags removal upstream