Skip to content

Update prepdocs to skip invalid files#2235

Open
mattgotteiner wants to merge 1 commit into
Azure-Samples:mainfrom
mattgotteiner:matt/prepdocs-skip-invalid-file
Open

Update prepdocs to skip invalid files#2235
mattgotteiner wants to merge 1 commit into
Azure-Samples:mainfrom
mattgotteiner:matt/prepdocs-skip-invalid-file

Conversation

@mattgotteiner

Copy link
Copy Markdown
Contributor

Purpose

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[X] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[X] No

Type of change

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

@pamelafox

Copy link
Copy Markdown
Collaborator

Per CI, you should try to figure out which exceptions are valid to catch- narrower is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants