Skip to content

Use exception filter to simplify conditional catch #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atifaziz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use exception filter to simplify conditional catch #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions BatchDotnetTutorialFfmpeg/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,17 +325,10 @@ private static async Task CreatePoolIfNotExistAsync(BatchClient batchClient, str

await pool.CommitAsync();
}
catch (BatchException be)
// Accept the specific error code PoolExists as that is expected if the pool already exists
catch (BatchException be) when (be.RequestInformation?.BatchError?.Code == BatchErrorCodeStrings.PoolExists)
{
// Accept the specific error code PoolExists as that is expected if the pool already exists
if (be.RequestInformation?.BatchError?.Code == BatchErrorCodeStrings.PoolExists)
{
Console.WriteLine("The pool {0} already existed when we tried to create it", poolId);
}
else
{
throw; // Any other exception is unexpected
}
Console.WriteLine("The pool {0} already existed when we tried to create it", poolId);
}
}

Expand Down