-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify networking architecture #123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove commented out line
Deployed this morning and it is much faster! (Even with the APIM Dev SKU). Still working through some testing but overall looks great. |
tushardhadiwal
previously approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Simple VNET helps the frontend app communicate with backend via APIM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overall goal of this PR is to simplify the networking architecture without loss of any security measures.
This PR incorporates several changes that were unfortunately difficult to separate into different PRs. They include:
Developer
andStandardV2
APIM tiers. TheDeveloper
tier is cheaper but requires more time to deploy. TheStandardV2
tier is more expensive but reduces the time to deploy. Pricing for each tier can be found here. Development teams will find theStandardV2
tier easier to work with due to the faster deployment time. Default behavior has been (and will remain to be) to deploy theDeveloper
tier unless a user overrides this decision (as documented in the deployment guide).deploy.sh
script and into a bicep implementation. This will allow users to leverage Azure in deploying resources in parallel and improve the investigation of any deployment errors.