Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify networking architecture #123

Merged
merged 29 commits into from
Aug 7, 2024

Conversation

jgbradley1
Copy link
Collaborator

@jgbradley1 jgbradley1 commented Aug 1, 2024

The overall goal of this PR is to simplify the networking architecture without loss of any security measures.

This PR incorporates several changes that were unfortunately difficult to separate into different PRs. They include:

  • Support for both Developer and StandardV2 APIM tiers. The Developer tier is cheaper but requires more time to deploy. The StandardV2 tier is more expensive but reduces the time to deploy. Pricing for each tier can be found here. Development teams will find the StandardV2 tier easier to work with due to the faster deployment time. Default behavior has been (and will remain to be) to deploy the Developer tier unless a user overrides this decision (as documented in the deployment guide).
  • Simplifies the overall deployment of multiple vnets (requiring network peering) down to a single vnet
  • Simplifies the deployment of graphrag in AKS be reducing the number of pods down to 1 (previous the accelerator would deploy graphrag as two separate AKS pods). Autoscaling via AKS is enabled.
  • In AKS, swapped out the use of a 3rd party nginx ingress service with an AKS built-in managed nginx service.
  • Pushes more Azure deployment logic out of the main deploy.sh script and into a bicep implementation. This will allow users to leverage Azure in deploying resources in parallel and improve the investigation of any deployment errors.

@jgbradley1 jgbradley1 requested a review from a team as a code owner August 1, 2024 20:25
@timothymeyers
Copy link
Contributor

Deployed this morning and it is much faster! (Even with the APIM Dev SKU). Still working through some testing but overall looks great.

tushardhadiwal
tushardhadiwal previously approved these changes Aug 6, 2024
Copy link
Member

@tushardhadiwal tushardhadiwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Simple VNET helps the frontend app communicate with backend via APIM.

@jgbradley1 jgbradley1 merged commit 4319144 into main Aug 7, 2024
7 checks passed
@jgbradley1 jgbradley1 deleted the joshbradley/simplify-vnet-networking branch August 7, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants