Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for 'cvm' image SKU in packer build process #5759

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

pineapplethevoyager
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@pineapplethevoyager
Copy link
Collaborator Author

image
Should I set SKU Name as well? (like done for 20_04-lts-cvm?

@pineapplethevoyager
Copy link
Collaborator Author

image
Should this install dependency change be applied to other cvms? I was able to get pipeline to build successfully without

@@ -67,7 +67,7 @@ if [[ ${OS_TYPE} == "Linux" && ${ENABLE_TRUSTED_LAUNCH} == "True" ]]; then
} \
} \
}"
elif [ "${OS_TYPE}" == "Linux" ] && [ "${IMG_SKU,,}" == "20_04-lts-cvm" ]; then
elif [ "${OS_TYPE}" == "Linux" ] && [[ "${IMG_SKU}" == "20_04-lts-cvm" || "${IMG_SKU}" == "cvm" ]]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does IMG_SKU='cvm' specifically imply 2404cvm? If that's the case, is there any reason why it's not named as 24_04-lts-cvm. I could be wrong, but from the naming it seems 'cvm' includes all SKUs ranging from 18.04 to 24.04 CVM.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMG_SKU is defined by ubuntu version. Currently the only sku that has img_sku == cvm is 2404.

But if the sku is CVM regardless of version it should need special cvm build that should be caught by this if sku==cvm

@Devinwong
Copy link
Collaborator

Devinwong commented Feb 7, 2025

image Should this install dependency change be applied to other cvms? I was able to get pipeline to build successfully without

I am not familiar with this either. But according to the comment, fix grub issue with cvm by reinstalling before other deps. other VHDs use grub-pc, not grub-efi. Can you double check if the image end up having the expected component installed? Seems we need to understand what is expected for 2404 cvm SKU first

@Devinwong
Copy link
Collaborator

image Should I set SKU Name as well? (like done for 20_04-lts-cvm?

It seems it's needed, though I didn't trace how the $SKU_NAME will be used later.

@pineapplethevoyager
Copy link
Collaborator Author

image Should this install dependency change be applied to other cvms? I was able to get pipeline to build successfully without

I am not familiar with this either. But according to the comment, fix grub issue with cvm by reinstalling before other deps. other VHDs use grub-pc, not grub-efi. Can you double check if the image end up having the expected component installed? Seems we need to understand what is expected for 2404 cvm SKU first

I checked release-notes and it appears no grub was installed I'll try adding this fix and see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants