-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add support for 'cvm' image SKU in packer build process #5759
base: master
Are you sure you want to change the base?
Conversation
…/Azure/AgentBaker into chrislopez/cvm2404-buildfixtures
@@ -67,7 +67,7 @@ if [[ ${OS_TYPE} == "Linux" && ${ENABLE_TRUSTED_LAUNCH} == "True" ]]; then | |||
} \ | |||
} \ | |||
}" | |||
elif [ "${OS_TYPE}" == "Linux" ] && [ "${IMG_SKU,,}" == "20_04-lts-cvm" ]; then | |||
elif [ "${OS_TYPE}" == "Linux" ] && [[ "${IMG_SKU}" == "20_04-lts-cvm" || "${IMG_SKU}" == "cvm" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does IMG_SKU='cvm' specifically imply 2404cvm? If that's the case, is there any reason why it's not named as 24_04-lts-cvm. I could be wrong, but from the naming it seems 'cvm' includes all SKUs ranging from 18.04 to 24.04 CVM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMG_SKU is defined by ubuntu version. Currently the only sku that has img_sku == cvm is 2404.
But if the sku is CVM regardless of version it should need special cvm build that should be caught by this if sku==cvm
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: