feat: update credential provider config to support non-anonymous ACR for network isolated cluster feature #5836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingosummer
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1,
timmy-wright,
zachary-bailey,
bravebeaver and
smith1511
as code owners
bingosummer
changed the title
bingosummer
force-pushed
the
binxi/ni-credential-provider
branch
from
10b9a18 to
ed188f2
Compare
|
LGTM |
mainred
reviewed
Feb 14, 2025
karataliu
reviewed
Feb 14, 2025
…for network isolated cluster feature
bingosummer
force-pushed
the
binxi/ni-credential-provider
branch
from
ed188f2 to
147a3d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
update credential provider config to support non-anonymous for network isolated cluster feature
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: