-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to extract and cache CoreDNS Binary in VHD for localdns #6082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yewmsft
reviewed
Mar 25, 2025
Devinwong
reviewed
Mar 26, 2025
Devinwong
reviewed
Mar 26, 2025
yewmsft
reviewed
Mar 26, 2025
yewmsft
reviewed
Mar 26, 2025
Manually tested both the functions on an AKS agent node.
and
|
yewmsft
reviewed
Mar 27, 2025
Devinwong
approved these changes
Mar 27, 2025
yewmsft
reviewed
Mar 27, 2025
yewmsft
approved these changes
Mar 27, 2025
No changes to cached containers or packages on Windows VHDs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
What this PR does / why we need it:
This PR adds a function to extract a coredns binary from cached coredns container images in the VHD. It extracts binary of n-1 coredns image version and latest revision version (v.Major.Minor.Patch-Revision) and copies it to /opt/azure/containers/localdns/binary/coredns path. This binary will be used by localdns systemd unit. The function also handles the cleanup of temporary directories and unmounting of images.
Which issue(s) this PR fixes:
Fixes # None
Requirements:
Build
Special notes for your reviewer:
Not sure if there is a way to write unit tests for this file.
Release note: