Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix get kubelet identity not retrying when imds has temp 400 response #6087

Merged
merged 9 commits into from
Mar 28, 2025

Conversation

fseldow
Copy link
Collaborator

@fseldow fseldow commented Mar 26, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:
We meet issue that imds will sometimes return 400 bad request. It will cause the cse directly exit without any more information. If it is VMSS cluster, the next instance will succeed, however, if it is vms, the cluster will fail

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@fseldow fseldow changed the title [NI] fix get kubelet identity not retrying when imds has temp 400 response bug: fix get kubelet identity not retrying when imds has temp 400 response Mar 26, 2025
Copy link
Contributor

@UtheMan UtheMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some questions/nit comments

Copy link
Contributor

No changes to cached containers or packages on Windows VHDs

@fseldow fseldow merged commit 3eeb00f into master Mar 28, 2025
21 checks passed
@fseldow fseldow deleted the xinhl/token branch March 28, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants