Skip to content

feat(Templates): Add Error Labeling for tabs #7098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 1, 2025
Merged

Conversation

Elaina-Lee
Copy link
Contributor

@Elaina-Lee Elaina-Lee commented Apr 25, 2025

Type of Change

  • Bug fix
  • Feature
  • Other

New Behavior

  • Showing error message bar for error workflows (workflows tab) and error parameters (parameters tab), intentionally without the content with reflecting concern it may be too long. More detailed error description are present when you go on individual workflow and parameter.
  • Changed intl text of image error messages as reviewed
  • Fixed settings tab to publish in all wordings
  • Running validation on publish tab as well as review tab
  • Better formatting of parameter error messages

Impact of Change

  • This is a breaking change.

Test Plan

Screenshots or Videos (if applicable)

image
image

@Elaina-Lee Elaina-Lee marked this pull request as ready for review April 25, 2025 23:11
@Elaina-Lee Elaina-Lee enabled auto-merge (squash) May 1, 2025 18:26
@Elaina-Lee Elaina-Lee merged commit 61e66e7 into main May 1, 2025
13 checks passed
@Elaina-Lee Elaina-Lee deleted the elaina/errorMsgToTabs branch May 1, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants