Skip to content

Commit

Permalink
Bug Fix: wrong invokation to call ./scripts/install_all.bat which let…
Browse files Browse the repository at this point in the history
… dependency check always pass on Windows platform (#11094)

* Bug fix: issue #9853 to make dependency check valid on Windows platform
  • Loading branch information
Jianhui Harold authored Nov 5, 2019
1 parent 94d3290 commit 3a0c004
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion scripts/ci/dependency_check.bat
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ if %errorlevel% neq 0 exit /b %errorlevel%
del baseline_deps.txt

Rem Install everything from our repository first.
.\scripts\install_full.bat
call .\scripts\install_full.bat
if %errorlevel% neq 0 exit /b %errorlevel%

pip check
Expand Down
3 changes: 1 addition & 2 deletions scripts/install_full.bat
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Rem This script is the windows counter-part to ./install_full.sh

pushd %~dp0..

set cmd="dir .\src\ /b | findstr /v azure-cli-testsdk"
for /f "tokens=*" %%e in (' %cmd% ') do (
pip install --no-deps .\src\%%e
Expand All @@ -11,5 +11,4 @@ set cmd="python .\scripts\get-python-version.py"
for /f "tokens=*" %%v in (' %cmd% ') do set SHORT_PY_VER=%%v
pip install -r .\src\azure-cli\requirements.%SHORT_PY_VER%.Windows.txt

echo %OUTPUT%
popd

0 comments on commit 3a0c004

Please sign in to comment.