Skip to content

Conversation

@rosanch
Copy link
Contributor

@rosanch rosanch commented Oct 28, 2021

Description
Expanding az acr connected-registry test capabilities.


This checklist is used to make sure that common guidelines for a pull request are followed.

@rosanch
Copy link
Contributor Author

rosanch commented Oct 28, 2021

@zhoxing-ms could I please get some guidance with the testing? Why is it not passing the test online but it does on my local machine?

image

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 28, 2021

@zhoxing-ms to help with

@yonzhan yonzhan requested a review from wangzelin007 October 28, 2021 23:05
@zhoxing-ms
Copy link
Contributor

@rosanch Could you invite me to participate in the development of your forked repo? I will the re-record yaml for you and upload it to this PR

Copy link
Member

@wangzelin007 wangzelin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangzelin007 wangzelin007 changed the title [ACR] Connected registry test upgrade [ACR] az acr connected-registry: test cases update Oct 29, 2021
@zhoxing-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@zhoxing-ms zhoxing-ms changed the title [ACR] az acr connected-registry: test cases update {ACR} az acr connected-registry: test cases update Dec 2, 2021
@rosanch
Copy link
Contributor Author

rosanch commented Dec 2, 2021

@rosanch Could you invite me to participate in the development of your forked repo? I will the re-record yaml for you and upload it to this PR

@zhoxing-ms did you have any access issues?

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Dec 6, 2021

@rosanch There is no permission problem.
I found that this issue is caused by the fact that the VCR did not record the get_token_from_id(cmd, connected_registry.parent.sync_properties.token_id) requests sent by acr connected-registry permissions show command.
This is usually caused by the inconsistency between the recorded yaml and the latest code. I re-recorded the yaml to solve this issue.

@zhoxing-ms zhoxing-ms merged commit ea7d384 into Azure:dev Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants