Skip to content

Conversation

@FumingZhang
Copy link
Member

Description

  • Not long ago, in aks-preview @tilnl-ms helped sorted out the internal operations required by some addons (PR #3911), and we are gradually synchronizing this part.
  • This would also fix a bug in the preparation process of monitoring addon.
  • This third PR focuses on replacing old implementations (in custom.py) and adjusting tests accordingly.
    • Replace the role assignment helper functions for monitoring, ingress-appgw, virtual node addons.
    • Replace log workspace and container insights preparation functions for the monitoring addon.
    • Adjust unit tests for latest profile, hybrid_2020_09_01 profile and decorator pattern.
    • Sync the latest change -> PR #4128

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 25, 2021

AKS

@FumingZhang
Copy link
Member Author

FumingZhang commented Nov 25, 2021

Live test results -> result 1 & result 2 (retry of previously failed cases).

@FumingZhang FumingZhang marked this pull request as ready for review November 26, 2021 05:23
@FumingZhang FumingZhang requested a review from jsntcy as a code owner November 26, 2021 05:23
@zhoxing-ms zhoxing-ms merged commit 0255495 into Azure:dev Nov 26, 2021
@FumingZhang FumingZhang deleted the fuming/acs-fix-workspace-id-part3 branch December 1, 2021 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants