{Compute} module command test #20788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxznmhdcxz
requested review from
jsntcy,
wangzelin007 and
zhoxing-ms
as code owners
wangzelin007
requested changes
Dec 22, 2021
Member
wangzelin007
left a comment
wangzelin007
left a comment
There was a problem hiding this comment.
@cxznmhdcxz,
Please fix CI errors, Other looks good to me.
added 3 commits
December 22, 2021 18:31
wangzelin007
approved these changes
Dec 23, 2021
cxznmhdcxz
changed the title
cxznmhdcxz
changed the title
zhoxing-ms
reviewed
Dec 27, 2021
src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add command test coverage and record live test.
Included commands:
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.