Skip to content

{Core} Update warning message for auth code flow #21140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 1 commit into from
Feb 7, 2022
Merged

{Core} Update warning message for auth code flow #21140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli-core/azure/cli/core/auth/identity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ def _service_principal_store(self):
def login_with_auth_code(self, scopes, **kwargs):
# Emit a warning to inform that a browser is opened.
# Only show the path part of the URL and hide the query string.
logger.warning("The default web browser has been opened at %s. Please continue the login in the web browser. "
logger.warning("A web browser has been opened at %s. Please continue the login in the web browser. "
Copy link
Member

@rayluo rayluo Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

By the way, in an upcoming feature branch, this behavior will likely change again. :-) But that is a topic for future. Right now, I think your PR here makes sense. Approving.

"If no web browser is available or if the web browser fails to open, use device code flow "
"with `az login --use-device-code`.", self._msal_app.authority.authorization_endpoint)

Expand Down