[ACR] az acr manifest: Add new command group
#21161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@zhoxing-ms for awareness |
wangzelin007
changed the title
az acr manifest command group
zhoxing-ms
changed the title
az acr manifest command groupaz acr manifest: Add new command group
zhoxing-ms
reviewed
Feb 10, 2022
zhoxing-ms
reviewed
Feb 11, 2022
zhoxing-ms
reviewed
Feb 17, 2022
zhoxing-ms
reviewed
Feb 17, 2022
zhoxing-ms
approved these changes
Feb 22, 2022
rosanch
approved these changes
Feb 23, 2022
| repository, tag, manifest = _parse_image_name(manifest_spec, allow_digest=True) | ||
|
|
||
| if not manifest: | ||
| image = repository + ':' + tag |
Contributor
There was a problem hiding this comment.
You use it several times. Might as well create a constant call repoTagLimiter or something like that
src/azure-cli/azure/cli/command_modules/acr/tests/latest/test_acr_commands_mock.py
Show resolved
Hide resolved
wangzelin007
approved these changes
Feb 24, 2022
Contributor
|
@rosanch I see you left a lot of comments but approved this PR. Do you think we can merge this PR? |
jsntcy
approved these changes
Feb 25, 2022
Contributor
|
@rosanch I see that everyone has approved it. In order to avoid delaying it until the next sprint release, I'll merge it first. If there is anything to be optimized, we can submit a new PR for release in the next sprint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
az acr manifestaz acr repository show-manifestscommandTesting Guide
name: Get the manifest of the artifact 'hello-world:latest'.
text: az acr manifest show -r MyRegistry -n hello-world:latest
name: List the manifests of the repository 'hello-world'.
text: az acr manifest list -r MyRegistry -n hello-world
name: Delete the manifest of the artifact 'hello-world:latest'.
text: az acr manifest delete -r MyRegistry -n hello-world:latest
name: List the referrers to the manifest of the artifact 'hello-world:latest'.
text: az acr manifest list-referrers -r MyRegistry -n hello-world:latest
name: Get the metadata of the tag 'hello-world:latest'.
text: az acr manifest metadata show -r MyRegistry -n hello-world:latest
name: List the metadata of the manifests in the repository 'hello-world'.
text: az acr manifest metadata list -r MyRegistry -n hello-world
name: Update the metadata of the tag 'hello-world:latest'.
text: az acr manifest metadata update -r MyRegistry -n hello-world:latest --write-enabled false
History Notes
[ACR]
az acr manifest: Add new command group to support managing artifact manifests in Azure Container Registries[ACR] Deprecate
az acr repository show-manifestscommand and replace withacr manifest metadata listcommandThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.