Skip to content

Conversation

@damodaravadhani
Copy link
Member

@damodaravadhani damodaravadhani commented Feb 4, 2022

Description
Adding MSI cmdlets. (az eventhubs namespace identity)
Adding MSI encryption cmdlets (az eventhubs namespace encryption)
Edited (az eventhubs namespace create) to include MSI properties

Testing Guide

Create namespace with user assigned identity encryption

az eventhubs namespace create --resource-group {resourcegroupname} --name {namespacename} --sku premium --capacity 1 --user-assigned {resourceIdOfMSI1} {resourceIdOfMSI2} --encryption-config key-name key1 key-vault-uri https://{uri} user-assigned-identity /subscriptions/{subscriptionid}/resourceGroups/{resourcegroupname}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{name} --encryption-config key-name {keyname} key-vault-uri {keyvaulturi} user-assigned-identity /subscriptions/{subscriptionid}/resourceGroups/{resourcegroupname}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{name}

Add encryption configs to created namespace

az eventhubs namespace encryption add --resource-group damorg --namespace-name testCLIMSISdkRound1 --encryption-config key-name key1 key-vault-uri https://{name}.vault.azure.net user-assigned-identity /subscriptions/{subscriptionid}/resourceGroups/{resourcegroupname}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{name} --encryption-config key-name key2 key-vault-uri https://{name}.vault.azure.net user-assigned-identity /subscriptions/{subscriptionid}/resourceGroups/{resourcegroupname}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{name}

Remove Encryption Configs from created namespace

az eventhubs namespace encryption remove --encryption-config key-name key1 key-vault-uri https://{name}.vault.azure.net user-assigned-identity /subscriptions/{subscriptionid}/resourceGroups/{resourcegroupname}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{name}

Add system assigned and user assigned identity to namespace

az eventhubs namespace identity assign --resource-group {rgname} --namespace-name {name} --system-assigned --user-assigned /subscriptions/{subscriptionid}/resourceGroups/{resourcegroupname}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{name}

Remove system assigned and user assigned identity from namespace

az eventhubs namespace identity remove --resource-group {rgname} --namespace-name {name} --system-assigned --user-assigned /subscriptions/{subscriptionid}/resourceGroups/{resourcegroupname}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{name}

History Notes

[EventHub] az eventhubs namespace create: Add --user-assigned, --system-assigned, --encryption-config
[EventHub] az eventhubs namespace identity: Cmdlets for event hubs identity
[EventHub] az eventhubs namespace encryption: Cmdlets for event hubs encryption


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 4, 2022

event hubs

@yonzhan yonzhan modified the milestones: Feb 2022 (2022-03-01), Backlog Feb 7, 2022
@damodaravadhani damodaravadhani changed the title Added identity, encryption cmdlets. Edited namespace create cmdlet to include MSI properties. [EventHub] Added identity, encryption cmdlets. Edited namespace create cmdlet to include MSI properties. Feb 7, 2022
@damodaravadhani
Copy link
Member Author

@yonzhan , could you please add the February 2022 (2022-03-01) tag to this PR. We want this merged for the Feb release. Thanks

@damodaravadhani damodaravadhani changed the title [EventHub] Added identity, encryption cmdlets. Edited namespace create cmdlet to include MSI properties. [EventHub] Added identity, encryption cmdlets and edited namespace create cmdlet to include MSI properties. Feb 10, 2022
@wangzelin007
Copy link
Member

@damodaravadhani,
Can you merge from the latest dev branch ?
The check Check the Format of Pull Request Title and Content had a bug and already fixed in the latest dev branch.

@damodaravadhani damodaravadhani changed the title [EventHub] Added identity, encryption cmdlets and edited namespace create cmdlet to include MSI properties. [EventHub] MSI: Added identity, encryption cmdlets and edited namespace create cmdlet to include MSI properties. Feb 12, 2022
@damodaravadhani damodaravadhani changed the title [EventHub] MSI: Added identity, encryption cmdlets and edited namespace create cmdlet to include MSI properties. [EventHub] MSI: Adding identity, encryption cmdlets and edited namespace create cmdlet to include MSI properties. Feb 12, 2022
@wangzelin007 wangzelin007 changed the title [EventHub] MSI: Adding identity, encryption cmdlets and edited namespace create cmdlet to include MSI properties. [EventHub] MSI: Add identity, encryption cmdlets and edited namespace create cmdlet to include MSI properties. Feb 14, 2022
@damodaravadhani damodaravadhani changed the title [EventHub] MSI: Add identity, encryption cmdlets and edited namespace create cmdlet to include MSI properties. [EventHub] Add identity, encryption cmdlets and edited namespace create cmdlet to include MSI properties. Feb 18, 2022
@damodaravadhani damodaravadhani changed the title [EventHub] Add identity, encryption cmdlets and edited namespace create cmdlet to include MSI properties. [EventHub] MSI: Add identity, encryption cmdlets and edited namespace create cmdlet to include MSI properties. Feb 18, 2022
@damodaravadhani
Copy link
Member Author

Could somebody please approve this PR? Thanks.

@yonzhan yonzhan requested a review from wangzelin007 February 22, 2022 06:13
@damodaravadhani
Copy link
Member Author

Could we merge this PR if there aren't any additional concerns ? Thank you.

@evelyn-ys evelyn-ys merged commit 403269d into Azure:dev Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants