Skip to content

Conversation

@FumingZhang
Copy link
Member

Description

This PR aims to fix the extraction of custom headers and add an option to allow multiple values to be appended to the same key.

Example: after the change, given the following option

--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/Feature1,AKSHTTPCustomFeatures=Microsoft.ContainerService/Feature2

the request header would be

- request:
    headers:
      AKSHTTPCustomFeatures: 
      - Microsoft.ContainerService/Feature1,Microsoft.ContainerService/Feature2

which used to be

- request:
    headers:
      AKSHTTPCustomFeatures: 
      - Microsoft.ContainerService/Feature2

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost requested a review from wangzelin007 March 21, 2022 09:28
@ghost ghost assigned zhoxing-ms Mar 21, 2022
@ghost ghost added this to the Mar 2022 (2022-04-06) milestone Mar 21, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Mar 21, 2022
@ghost ghost requested a review from yonzhan March 21, 2022 09:28
@ghost ghost added the AKS az aks/acs/openshift label Mar 21, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 21, 2022

AKS

@zhoxing-ms zhoxing-ms merged commit 46fbdea into Azure:dev Mar 22, 2022
@FumingZhang FumingZhang deleted the fuming/fix-custom-header-extraction-0321 branch April 6, 2022 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS az aks/acs/openshift Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants