Skip to content

{Storage} Grant proper access on azcopy installation #21714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evelyn-ys merged 2 commits into from
Mar 29, 2022
Merged

{Storage} Grant proper access on azcopy installation #21714

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bbe92d
Grant proper access on azcopy installation
evelyn-ys Mar 21, 2022
2e78000
Merge remote-tracking branch 'upstream/dev' into storage_azcopy_write…
evelyn-ys Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/azure-cli/azure/cli/command_modules/storage/azcopy/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ def install_azcopy(self, install_location):
else:
raise CLIError('Azcopy ({}) does not exist.'.format(self.system))
try:
os.chmod(install_dir,
os.stat(install_dir).st_mode | stat.S_IWUSR | stat.S_IWGRP | stat.S_IWOTH)
os.chmod(install_dir, os.stat(install_dir).st_mode | stat.S_IWUSR)
Copy link
Member

@jiasli jiasli Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems stat.S_IWUSR is set by default:

import os
import stat
install_dir = 'temp'
os.makedirs(install_dir)
print(bool(os.stat(install_dir).st_mode & stat.S_IWUSR))

Output:

True

stat.S_IWUSR is not explicitly set when downloading bicep CLI:

azure-cli/src/azure-cli/azure/cli/command_modules/resource/_bicep.py

Lines 104 to 106 in 9464462

installation_dir = os.path.dirname(installation_path)
if not os.path.exists(installation_dir):
os.makedirs(installation_dir)

_urlretrieve(file_url, install_location)
os.chmod(install_location,
os.stat(install_location).st_mode | stat.S_IXUSR | stat.S_IXGRP | stat.S_IXOTH)
Expand Down