-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Network] Fix #21716: az network private-dns zone import: Allow hyphenated SRV records
#21717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Network |
|
@huws Overall LGTM, but please refine the PR title and rebase with the latest changes from dev branch. |
az network private-dns zone import fails for hyphenated SRV records
az network private-dns zone import fails for hyphenated SRV recordsaz network private-dns zone import: Allow hyphenated SRV records
necusjz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huws, I was aware that this PR introduced too many others' commits, i.e., too many unrelated file changes. So, please make it clean and only introduce related changes. Thanks.
e040309 to
d7ecadf
Compare
|
Apologies - not sure what happened, there. The PR is now clean - just my one commit. |
|
@huws never mind, our CI was also down at that moment. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Description
This is necessary to allow hyphenated SRV records targets to be successfully imported. Today, such imports fail, as described in #21716
Testing Guide
Without the fix, importing this valid zone file (
db.example.com) will fail:Failure output from import using
az network private-dns zone import --resource-group <RG NAME> --name example.com --file-name db.example.com:With the fix, this import succeeds with the output:
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.