backport: ci: add delay after link creation for test add remove static arp (#2968) #3556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix by adding delay after link creation
There was a problem hiding this comment.
Pull Request Overview
A backport PR to add delays in the static ARP test to ensure that the network interface is fully up before ARP entries are modified.
- Added the time package and inserted delays before and after setting the ARP entries.
- Updated comments to clarify the timing rationale in the test.
Comments suppressed due to low confidence (2)
netlink/netlink_test.go:291
- [nitpick] Consider replacing the hardcoded delay value with a clearly named constant (e.g., interfaceUpDelay) to improve readability and ease future adjustments.
time.Sleep(time.Millisecond * 100)
netlink/netlink_test.go:311
- [nitpick] Similarly, consider using a named constant (e.g., arpPersistenceDelay) for this delay to clarify its purpose and allow for easier configuration changes.
time.Sleep(time.Millisecond * 100)
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jpayne3506
approved these changes
Apr 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MikeZappa87
reviewed
Apr 3, 2025
| @@ -285,6 +286,10 @@ func TestAddRemoveStaticArp(t *testing.T) { | |||
| mac, _ := net.ParseMAC("aa:b3:4d:5e:e2:4a") | |||
| nl := NewNetlink() | |||
|
|
|||
| // wait for interface to fully come up | |||
| // if it isn't fully up it might wipe the arp entry we're about to add | |||
| time.Sleep(time.Millisecond * 100) | |||
There was a problem hiding this comment.
Are we waiting for a specific state here? We should avoid this type of behavior and explicitly wait for a state of the netdev and timeout if the expected state is never seen.
The problem with this is it can result in flakes depending on several factors. Let’s be deterministic with this instead.
MikeZappa87
requested changes
Apr 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix by adding delay after link creation
Reason for Change:
Backports #2968
Issue Fixed:
See above
Requirements:
Notes: