Update ACN Pipeline for Compliance #3597
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ACN pipelines for compliance by standardizing pool configurations and enhancing Dockerfile reference management. Key changes include:
- Updated pool definitions in multiple pipeline templates to use "type: linux" and "isCustom: true".
- Removal of outdated steps in the aks-swift E2E step template.
- Introduction of new utility scripts for renaming Dockerfile references along with enhancements to build and manifest generation steps.
Reviewed Changes
Copilot reviewed 48 out of 57 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .pipelines/singletenancy/aks/e2e-job-template.yaml | Added custom pool settings for improved job configuration. |
| .pipelines/singletenancy/aks-swift/e2e-step-template.yaml | Removed legacy environment setup steps. |
| .pipelines/singletenancy/aks-swift/e2e-job-template.yaml | Standardized pool setups and added checkout steps. |
| .pipelines/cni/k8s-e2e/k8s-e2e-job-template.yaml | Updated pool configuration and inserted a checkout step. |
| .pipelines/build/utils/rename-dockerfile-references.steps.yaml | Introduced new utility steps for Dockerfile renaming. |
| .pipelines/build/publish-manifest.steps.yaml | Added new steps to publish manifest data. |
| .pipelines/build/ob-prepare.steps.yaml | Integrated new Dockerfile renaming templates and cleanup. |
| .pipelines/build/manifests.jobs.yaml | Added jobs to generate and publish image manifests. |
| .pipelines/build/image.steps.yaml | Refined image build and output steps with updated arguments. |
| .pipelines/build/generate-manifest.steps.yaml | Created steps to populate image manifest data using jq. |
| .pipelines/build/binary.steps.yaml | Added steps to build binaries with pre-requisites and artifact preparation. |
Files not reviewed (9)
- .pipelines/OneBranch.NonOfficial.CrossPlat.yaml: Language not supported
- .pipelines/OneBranch.Official.CrossPlat.yaml: Language not supported
- .pipelines/cni/k8s-e2e/k8s-e2e.jobs.yaml: Language not supported
- .pipelines/containers/container-template.steps.yaml: Language not supported
- .pipelines/containers/manifest-template.steps.yaml: Language not supported
- .pipelines/multitenancy/swiftv2-e2e.jobs.yaml: Language not supported
- .pipelines/singletenancy/aks-swift/aks-swift-e2e.jobs.yaml: Language not supported
- .pipelines/singletenancy/aks/aks-e2e.jobs.yaml: Language not supported
- .pipelines/singletenancy/aks/aks-e2e.steps.yaml: Language not supported
Comments suppressed due to low confidence (1)
.pipelines/build/utils/rename-dockerfile-references.steps.yaml:7
- The word 'fascilitates' appears to be misspelled. Consider replacing it with 'facilitates'.
# 'Dockerfile'. This fascilitates the creation of this template in order to
| # $target_dockerfile. This is a dumb sed replace; set with care. | ||
| # | ||
| # replace_path (string|default) - The directory for which to search for | ||
| # references to the old dockerfile name. Replce will default to $target_path |
There was a problem hiding this comment.
The word 'Replce' appears to be misspelled. Consider replacing it with 'Replace'.
Suggested change
| # references to the old dockerfile name. Replce will default to $target_path | |
| # references to the old dockerfile name. Replace will default to $target_path |
Copilot uses AI. Check for mistakes.
| mkdir -p "$TARGET_REL_PATH" | ||
| cp -r "$SOURCE_REL_PATH"/* "$TARGET_REL_PATH" | ||
| else | ||
| echo >&2 "##[info]Target path ('$TARGET_REL_PATH') exits. Nothing to do." |
There was a problem hiding this comment.
The word 'exits' seems to be a typo. Consider replacing it with 'exists'.
Suggested change
| echo >&2 "##[info]Target path ('$TARGET_REL_PATH') exits. Nothing to do." | |
| echo >&2 "##[info]Target path ('$TARGET_REL_PATH') exists. Nothing to do." |
Copilot uses AI. Check for mistakes.
sheylatrudo
force-pushed
the
smtrudo/acn-onebranch
branch
from
0a8eb80 to
69f9083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: