Enable metric collection on long running cluster test pipeline. #4204
+156
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scheduled runs from eastus2 to westus2 for TIP session availability.
Contributor
There was a problem hiding this comment.
Pull request overview
Integrates persistent cluster metrics emission into the swiftv2 long-running cluster test pipeline to improve observability of per-stage test outcomes.
Changes:
- Adds a
BuildMetricsBinaryjob that builds and publishes thepersistent-cluster-metricsbinary as a pipeline artifact. - Wraps each datapath test stage (
create,connectivity,private endpoint,scale,delete) to emit success/failure metrics aftergo test. - Switches the pipeline default deployment region from
eastus2towestus2.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.pipelines/swiftv2-long-running/template/datapath-tests-stage.yaml |
Builds/downloads metrics binary and emits success/failure metrics per test job; updates storage RBAC script paths for multi-repo layout. |
.pipelines/swiftv2-long-running/pipeline.yaml |
Changes default location parameter to westus2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.pipelines/swiftv2-long-running/template/datapath-tests-stage.yaml
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulyufan2
previously approved these changes
Jan 27, 2026
kmurudi
reviewed
Jan 29, 2026
.pipelines/swiftv2-long-running/template/datapath-tests-stage.yaml
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kmurudi
approved these changes
Jan 29, 2026
shreyashastantram
approved these changes
Feb 2, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 2, 2026
* Enable metric collection on long running cluster test pipeline. Move scheduled runs from eastus2 to westus2 for TIP session availability. * Refactor: extract metrics setup steps into reusable template * remove redundant dependencies. --------- Co-authored-by: sivakami <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Add observability to the swiftv2 long running cluster test pipeline by integrating metrics collection.
Issue Fixed:
This PR integrates the persistent-cluster-metrics tool to report test outcomes (success/failure) for each test stage to our telemetry system.
test run on long running cluster pipeline
Changes:
Build the metrics binary from Networking-Aquarius repo during pipeline execution
After each test (pod creation, connectivity, private endpoint, scale, cleanup), report the result as a metric
Switch default region to westus2 (temporary - eastus2 TIP sessions unavailable)
Metrics emitted:
https://amg-persistent-metrics-ccawb9g7hecucsh2.wus2.grafana.azure.com/goto/a0zNbRHDR?orgId=1
PersistentClusterTestsSucceeded - when a test passes
PersistentClusterTestsFailed - when a test fails
Each metric includes: ADO run ID, resource group, work load type, and test scenario name.